-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolset update: VS 2022 17.3 Preview 3, Clang 14 #2861
Toolset update: VS 2022 17.3 Preview 3, Clang 14 #2861
Conversation
"Standard Library Header Units: <expected> ICEs with Assertion failed: IsInClassDefn()"
…expr In optional And variant.
…d::array Comparisons.
Adjust the locale name to "en-US.UTF-8", for consistency with other tests. If an exception is thrown, the message is no longer a warning - the test will fail.
This bug is still active. Perma-workaround: Mark the lambdas as constexpr, for consistency with other lambdas here.
…all good, no manual changes.
…s, all good, no manual changes.
…good, no manual changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way of splitting up commits that you've done has made this extremely easy to review.
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
@strega-nil-ms I've pushed an additional commit, @CaseyCarter's workaround for #2862 (which happens only in the internal test harness where the STL lives next to the compiler toolset). |
Co-authored-by: Casey Carter <[email protected]>
As a whole, this is best reviewed by ignoring whitespace. I've also arranged it as a series of well-structured commits.
🧰 Toolset update
🚀 Clang 14 coroutines
<coroutine>
test coverage for Clang.P0912R5_coroutine
.<coroutine>
ICE: failed to perform tail call elimination on a call site marked musttail".🩹 Workaround removals
<expected>
ICEs with Assertion failed:IsInClassDefn()
"_MSVC_EXECUTION_CHARACTER_SET
.__STDCPP_DEFAULT_NEW_ALIGNMENT__
should havesize_t
type", resolved on 2018-01-02.constexpr
Inoptional
Andvariant
(P2231 Completing constexpr in optional and variant #2005).constinit
", fixed in 17.2.constexpr
Forstd::array
Comparisons (constexpr for std::array Comparisons #599).not_ranges_destroy()
workarounds now that we've implementedranges::destroy
(Minimal changes to support constexpr allocation in MSVC #1313).TRANSITION, VSO-1172852
("Coroutine not at final suspend point after throwing fromunhandled_exception
") in<experimental/generator>
as this is permanent.WideCharToMultiByte
from_Wcrtomb
withCP_UTF8
", as our tests now assume modern OSes."en-US.UTF-8"
, for consistency with other tests.constexpr
".constexpr
, for consistency with other lambdas here.📄 clang-format 14
= default
/= delete
, no manual changes.requires
reference parameters, all good, no manual changes.